Skip to content

make webgl2 padding consistent #22357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mockersf merged 1 commit into from
Jan 13, 2026
Merged

make webgl2 padding consistent #22357

mockersf merged 1 commit into from
Jan 13, 2026
+17 −17

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 2, 2026

Objective

  • correct some names to specify webgl2 instead of wasm (webgpu does not require this alignment)
  • correct feature gates to only add the padding to structs on webgl2 and not webgpu
  • correct feature gates to only set SIXTEEN_BYTE_ALIGNMENT shader def on webgl2 and not webgpu

Solution

  • do it

Testing

  • untested

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 2, 2026
superdump
superdump approved these changes Jan 3, 2026
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yey, correctness! Thank you!

@superdump
Copy link
Contributor

superdump commented Jan 3, 2026

I would wait to merge for some testing to have been done that exercises each of the code paths.

@kfc35 kfc35 added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Testing Testing must be done before this is safe to merge labels Jan 8, 2026
@kristoff3r
Copy link
Contributor

kristoff3r commented Jan 12, 2026

I tested a bunch of the examples, including testbed_2d and testbed_3d on both webgl2 and webgpu, and they look good to me.

@kristoff3r kristoff3r added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Needs-Testing Testing must be done before this is safe to merge labels Jan 12, 2026
@mockersf mockersf added this pull request to the merge queue Jan 13, 2026
Merged via the queue into bevyengine:main with commit f09e04f Jan 13, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@superdump superdump superdump approved these changes

@mockersf mockersf mockersf approved these changes

+3 more reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@kfc35 kfc35 kfc35 approved these changes

@aevyrie aevyrie aevyrie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@atlv24 @superdump @kristoff3r @kfc35 @aevyrie @mockersf